Fix WiFi.persistent(false); having no effect. #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR calls `esp_wifi_set_storage(WIFI_STORAGE_RAM);` when persistent WiFi configuration is not desired.
|
@everslick if you set persistent=false, does it erase the previously stored credentials? Or does it just not store the next presented credentials? Chuck |
|
To my understanding, it will not erase the config that is already stored in NVS. There is a esp_wifi_restore() function, that will reset the config to its defaults, but this is never used. Personally I'd prefer if the ESP32 would only do what it is told to. i.e. NOW connect to SSID, NOW start AP, NOW disconnect from SSID, NOW disable AP. Never store anything in NVS on your own, never connect to anything on your own. But from the API it is hard to deduce which call to which methods in which order will do that. |
|
Going to move these to #1393 |
Curclamas
pushed a commit
to Curclamas/arduino-esp32
that referenced
this pull request
Aug 21, 2018
This PR calls `esp_wifi_set_storage(WIFI_STORAGE_RAM);` when persistent WiFi configuration is not desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR calls
esp_wifi_set_storage(WIFI_STORAGE_RAM);when persistent WiFi configuration is not desired.according to the ESP32 API reference guide the default is to store WiFi configuration in NVS.
esp_err_t esp_wifi_set_storage(wifi_storage_tstorage)
Set the WiFi API configuration storage type.
Attention